beliefer commented on code in PR #50219:
URL: https://github.com/apache/spark/pull/50219#discussion_r1986579208
##########
core/src/test/scala/org/apache/spark/rpc/TestRpcEndpoint.scala:
##########
@@ -26,15 +26,15 @@ class TestRpcEndpoint extends ThreadSafeRpcEndpoint with
TripleEquals {
override val rpcEnv: RpcEnv = null
- @volatile private var receiveMessages = ArrayBuffer[Any]()
+ @volatile private val receiveMessages = ArrayBuffer[Any]()
Review Comment:
It seems you must fix them. :)
```
[error]
/home/runner/work/spark/spark/core/src/test/scala/org/apache/spark/rpc/TestRpcEndpoint.scala:29:25:
values cannot be volatile
[error] @volatile private val receiveMessages = ArrayBuffer[Any]()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
