beliefer commented on code in PR #50221:
URL: https://github.com/apache/spark/pull/50221#discussion_r1987078528
##########
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/HadoopCompressionCodec.java:
##########
@@ -53,11 +51,16 @@ public CompressionCodec getCompressionCodec() {
return this.compressionCodec;
}
- private static final Map<String, String> codecNameMap =
- Arrays.stream(HadoopCompressionCodec.values()).collect(
- Collectors.toMap(Enum::name, codec ->
codec.name().toLowerCase(Locale.ROOT)));
+ private static final EnumMap<HadoopCompressionCodec, String> codecNameMap =
Review Comment:
It brings extra transform from java.util.Map to EnumMap. How about ?
```
private static final EnumMap<HadoopCompressionCodec, String> codecNameMap =
Arrays.stream(HadoopCompressionCodec.values()).collect(
Collectors.toMap(
codec -> codec,
codec -> codec.name().toLowerCase(Locale.ROOT),
(oldValue, newValue) -> oldValue,
() -> new EnumMap<>(HadoopCompressionCodec.class)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
