sandip-db commented on code in PR #50052:
URL: https://github.com/apache/spark/pull/50052#discussion_r1986121542
##########
sql/core/src/test/scala/org/apache/spark/sql/CsvFunctionsSuite.scala:
##########
@@ -760,12 +760,9 @@ class CsvFunctionsSuite extends QueryTest with
SharedSparkSession {
context = ExpectedContext(fragment = "to_csv",
getCurrentClassCallSitePattern)
)
- checkError(
- exception = intercept[SparkUnsupportedOperationException] {
- df.select(from_csv(lit("data"), valueSchema, Map.empty[String,
String])).collect()
- },
- condition = "UNSUPPORTED_DATATYPE",
- parameters = Map("typeName" -> "\"VARIANT\"")
+ checkAnswer(
+ df.select(from_csv(lit("1,2,3"), valueSchema, Map.empty[String,
String])),
+ Seq(Row(Row(1L, "2", new VariantVal(Array[Byte](12, 3), Array[Byte](1,
0, 0)))))
)
Review Comment:
Move this to a new test and also add `singleVariantColumn` scenario for
`from_csv`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
