cloud-fan commented on code in PR #49955:
URL: https://github.com/apache/spark/pull/49955#discussion_r1985046279
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/cteOperators.scala:
##########
@@ -40,7 +40,8 @@ case class UnionLoop(
id: Long,
anchor: LogicalPlan,
recursion: LogicalPlan,
- limit: Option[Int] = None) extends UnionBase {
+ localLimit: Option[Int] = None,
+ globalLimit: Option[Int] = None) extends UnionBase {
Review Comment:
nit: how about
```
limit: Int = -1,
isGlobal: Boolean = false
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/cteOperators.scala:
##########
@@ -40,7 +40,8 @@ case class UnionLoop(
id: Long,
anchor: LogicalPlan,
recursion: LogicalPlan,
- limit: Option[Int] = None) extends UnionBase {
+ localLimit: Option[Int] = None,
+ globalLimit: Option[Int] = None) extends UnionBase {
Review Comment:
nit: how about
```
limit: Int = -1,
isGlobalLimit: Boolean = false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
