cloud-fan commented on code in PR #50208:
URL: https://github.com/apache/spark/pull/50208#discussion_r1985031301
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1037,10 +1034,26 @@ trait CheckAnalysis extends LookupCatalog with
QueryErrorsBase with PlanToString
if (expr.plan.isStreaming) {
plan.failAnalysis("INVALID_SUBQUERY_EXPRESSION.STREAMING_QUERY",
Map.empty)
}
+ assertNoRecursiveCTE(expr.plan)
checkAnalysis0(expr.plan)
ValidateSubqueryExpression(plan, expr)
}
+ private def assertNoRecursiveCTE(plan: LogicalPlan): Unit = {
+ plan.foreach {
Review Comment:
it calls `plan.subqueries` which also collects subqueries first before
traversal. Maybe we should improve that method and then use it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
