wengh commented on code in PR #49961: URL: https://github.com/apache/spark/pull/49961#discussion_r1984640102
########## python/pyspark/sql/datasource.py: ########## @@ -234,6 +249,62 @@ def streamReader(self, schema: StructType) -> "DataSourceStreamReader": ) +ColumnPath = Tuple[str, ...] + + +@dataclass(frozen=True) +class Filter(ABC): + """ + The base class for filters used for filter pushdown. + + .. versionadded: 4.1.0 + + Notes + ----- + Column references are represented as a tuple of strings. For example: + + +----------------+----------------------+ + | Column | Representation | + +----------------+----------------------+ + | `col1` | `("col1",)` | Review Comment: this is a python syntax to disambiguate between 1-tuple and expression, removing the comma changes meaning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org