JoshRosen commented on code in PR #50167:
URL: https://github.com/apache/spark/pull/50167#discussion_r1984355016
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -6623,12 +6623,14 @@ class SQLConf extends Serializable with Logging with
SqlApiConf {
/** Return the value of Spark SQL configuration property for the given key.
*/
@throws[NoSuchElementException]("if key is not set")
def getConfString(key: String): String = {
- Option(settings.get(key)).
- orElse {
- // Try to use the default value
- Option(getConfigEntry(key)).map { e =>
e.stringConverter(e.readFrom(reader)) }
- }.
- getOrElse(throw QueryExecutionErrors.sqlConfigNotFoundError(key))
+ getConfStringOption(key).getOrElse(throw
QueryExecutionErrors.sqlConfigNotFoundError(key))
+ }
+
+ private[sql] def getConfStringOption(key: String): Option[String] = {
+ Option(settings.get(key)).orElse {
+ // Try to use the default value
+ Option(getConfigEntry(key)).map { e =>
e.stringConverter(e.readFrom(reader)) }
Review Comment:
Submitted a revert PR here: Sub
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -6623,12 +6623,14 @@ class SQLConf extends Serializable with Logging with
SqlApiConf {
/** Return the value of Spark SQL configuration property for the given key.
*/
@throws[NoSuchElementException]("if key is not set")
def getConfString(key: String): String = {
- Option(settings.get(key)).
- orElse {
- // Try to use the default value
- Option(getConfigEntry(key)).map { e =>
e.stringConverter(e.readFrom(reader)) }
- }.
- getOrElse(throw QueryExecutionErrors.sqlConfigNotFoundError(key))
+ getConfStringOption(key).getOrElse(throw
QueryExecutionErrors.sqlConfigNotFoundError(key))
+ }
+
+ private[sql] def getConfStringOption(key: String): Option[String] = {
+ Option(settings.get(key)).orElse {
+ // Try to use the default value
+ Option(getConfigEntry(key)).map { e =>
e.stringConverter(e.readFrom(reader)) }
Review Comment:
Submitted a revert PR here: https://github.com/apache/spark/pull/50200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
