beliefer commented on code in PR #49528:
URL: https://github.com/apache/spark/pull/49528#discussion_r1983217198
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala:
##########
@@ -58,17 +59,20 @@ class JdbcRelationProvider extends CreatableRelationProvider
// In this case, we should truncate table and then load.
truncateTable(conn, options)
val tableSchema = JdbcUtils.getSchemaOption(conn, options)
- saveTable(df, tableSchema, isCaseSensitive, options)
+ saveTable(df, tableSchema, isCaseSensitive, upsert, options)
Review Comment:
It looks strange that apply `upsert` if `SaveMode` is `Overwrite` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
