pan3793 commented on code in PR #50173:
URL: https://github.com/apache/spark/pull/50173#discussion_r1982635542
##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/AmIpFilterSuite.scala:
##########
@@ -162,8 +162,10 @@ class AmIpFilterSuite extends SparkFunSuite {
assert(!filter.getProxyAddresses.isEmpty)
// waiting for configuration update
eventually(timeout(5.seconds), interval(500.millis)) {
- assertThrows[ServletException] {
+ try {
filter.getProxyAddresses.isEmpty
Review Comment:
I understand that, my point is that unlike `GenericTestUtils.waitFor` tests
the body returning `true` or `false`, `eventually` tests the block whether to
throw an exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
