cloud-fan commented on code in PR #50044:
URL: https://github.com/apache/spark/pull/50044#discussion_r1980732719
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala:
##########
@@ -400,18 +401,23 @@ abstract class InMemoryBaseTable(
val sizeInBytes = numRows * rowSizeInBytes
val numOfCols = tableSchema.fields.length
- val dataTypes = tableSchema.fields.map(_.dataType)
- val colValueSets = new Array[util.HashSet[Object]](numOfCols)
+ val colValueSets = new Array[util.HashSet[Any]](numOfCols)
val numOfNulls = new Array[Long](numOfCols)
for (i <- 0 until numOfCols) {
- colValueSets(i) = new util.HashSet[Object]
+ colValueSets(i) = new util.HashSet[Any]
}
inputPartitions.foreach(inputPartition =>
inputPartition.rows.foreach(row =>
for (i <- 0 until numOfCols) {
- colValueSets(i).add(row.get(i, dataTypes(i)))
- if (row.isNullAt(i)) {
+ val field = tableSchema(i)
+ val colValue = if (i < row.numFields) {
+ row.get(i, field.dataType)
+ } else {
+ ResolveDefaultColumns.getExistenceDefaultValue(field)
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
