dongjoon-hyun commented on code in PR #50149:
URL: https://github.com/apache/spark/pull/50149#discussion_r1979644060
##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -278,15 +278,15 @@ private long trySpillAndAcquire(
}
} catch (ClosedByInterruptException | InterruptedIOException e) {
// This called by user to kill a task (e.g: speculative task).
- logger.error("error while calling spill() on {}", e,
+ logger.error("Error while calling spill() on {}", e,
Review Comment:
Could you revert this irrelevant changes from this PR, @pan3793 ?
##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -278,15 +278,15 @@ private long trySpillAndAcquire(
}
} catch (ClosedByInterruptException | InterruptedIOException e) {
// This called by user to kill a task (e.g: speculative task).
- logger.error("error while calling spill() on {}", e,
+ logger.error("Error while calling spill() on {}", e,
MDC.of(LogKeys.MEMORY_CONSUMER$.MODULE$, consumerToSpill));
throw new RuntimeException(e.getMessage());
} catch (IOException e) {
- logger.error("error while calling spill() on {}", e,
+ logger.error("Error while calling spill() on {}", e,
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
