HeartSaVioR commented on code in PR #50030:
URL: https://github.com/apache/spark/pull/50030#discussion_r1978582798
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/streaming/ClientStreamingQuerySuite.scala:
##########
@@ -56,8 +56,8 @@ class ClientStreamingQuerySuite extends QueryTest with
RemoteSparkSession with L
test("Streaming API with windowed aggregate query") {
// This verifies standard streaming API by starting a streaming query with
windowed count.
withSQLConf(
- "spark.sql.shuffle.partitions" -> "1" // Avoid too many reducers.
- ) {
+ "spark.sql.shuffle.partitions" -> "1", // Avoid too many reducers.
+ "spark.sql.streaming.stateStore.numStateStoreInstanceMetricsToReport" ->
"0") {
Review Comment:
This is needed because of the below assertion:
```
lastProgress.stateOperators.head.customMetrics.keySet().asScala == Set(
"loadedMapCacheHitCount",
"loadedMapCacheMissCount",
"stateOnCurrentVersionSizeBytes"))
```
Do I understand correctly?
Technically you can even verify the metric here, but I'd be OK not to change
existing tests to verify more thing while we are expected to add the test to
cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
