longvu-db commented on code in PR #50135:
URL: https://github.com/apache/spark/pull/50135#discussion_r1977963371
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -845,31 +848,42 @@ class AstBuilder extends DataTypeAstBuilder
// 2. Write commands do not hold the table logical plan as a child,
and we need to add
// additional resolution code to resolve identifiers inside the
write commands.
case table: InsertIntoTableContext =>
- val (relationCtx, options, cols, partition, ifPartitionNotExists,
byName)
- = visitInsertIntoTable(table)
+ val InsertTableParams(
Review Comment:
Ah yes 🤦 , great point Bart!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
