milosstojanovic commented on code in PR #50060:
URL: https://github.com/apache/spark/pull/50060#discussion_r1977786135


##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MsSqlServerIntegrationSuite.scala:
##########
@@ -91,6 +91,14 @@ class MsSqlServerIntegrationSuite extends 
DockerJDBCIntegrationV2Suite with V2JD
          |)
                    """.stripMargin
     ).executeUpdate()
+    connection.prepareStatement("CREATE TABLE employee_rpadlpad_test (dept 
INTEGER, name VARCHAR(32)")
+      .executeUpdate()
+    connection.prepareStatement("INSERT INTO employee_rpadlpad_test VALUES (1, 
'spark'")
+      .executeUpdate()
+    connection.prepareStatement("INSERT INTO employee_rpadlpad_test VALUES (2, 
'xxxx'")
+      .executeUpdate()
+    connection.prepareStatement("INSERT INTO employee_rpadlpad_test VALUES (3, 
'xxxxxxxxxx'")
+      .executeUpdate()

Review Comment:
   It messes up other tests if I re-use the same table and add more rows so 
would create dedicated one if it is not an issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to