MaxGekk commented on code in PR #50103:
URL: https://github.com/apache/spark/pull/50103#discussion_r1977596363
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -6190,6 +6190,12 @@
],
"sqlState" : "42000"
},
+ "UNSUPPORTED_TIME_PRECISION" : {
Review Comment:
IMHO, the error message already contains enough details including what you
pointed out, and the condition name should comprise of minimum info which is
enough to distinguish it from others. Also the error is about the `precision`
parameter of the `TIME` type:
```scala
case class TimeType(precision: Int)
```
from this point of view, it is self-descriptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
