cloud-fan commented on code in PR #50118:
URL: https://github.com/apache/spark/pull/50118#discussion_r1977587722
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewResolution.scala:
##########
@@ -52,4 +54,12 @@ object ViewResolution {
view.copy(child = newChild)
}
+
+ def getViewResolutionConf(viewDescription: CatalogTable, isTempView:
Boolean): SQLConf = {
+ var viewSQLConfigs = viewDescription.viewSQLConfigs ++ Map(
+ SQLConf.PLAN_CHANGE_LOG_LEVEL.key -> conf.planChangeLogLevel,
+ SQLConf.EXPRESSION_TREE_CHANGE_LOG_LEVEL.key ->
conf.expressionTreeChangeLogLevel
Review Comment:
shall we put this handling in `View.effectiveSQLConf`? It already has some
special handling to retain session configs under certain cases and we can add
more there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
