HeartSaVioR commented on PR #50124: URL: https://github.com/apache/spark/pull/50124#issuecomment-2694310674
@beliefer I agree that this is not a latency sensitive change - I can imagine some extreme case where this could still help, but I couldn't say that case is not an edge case. Though I still see this to be a lot better code than before, because this is now very clear about the behavior of "when data is available on the iterator" vs "when the iterator is fully consumed". I don't know whether the code was written from the time where NextIterator wasn't available, but this is really fit to the use case of NextIterator. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
