cloud-fan commented on code in PR #50074:
URL: https://github.com/apache/spark/pull/50074#discussion_r1974717022


##########
sql/core/src/test/resources/sql-tests/results/describe.sql.out:
##########
@@ -890,6 +890,48 @@ a                          string                  
CONCAT('a\n b\n ', 'c\n d')
 b                      int                     42
 
 
+-- !query
+CREATE TABLE f PARTITIONED BY (B, C) AS SELECT 'APACHE' A, CAST('SPARK' AS 
BINARY) B, TIMESTAMP'2018-11-17 13:33:33' C
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DESC FORMATTED f PARTITION (B='SPARK', C=TIMESTAMP'2018-11-17 13:33:33')
+-- !query schema
+struct<col_name:string,data_type:string,comment:string>
+-- !query output
+A                      string                                      
+B                      binary                                      
+C                      timestamp                                   
+# Partition Information                                                    
+# col_name             data_type               comment             
+B                      binary                                      
+C                      timestamp                                   
+                                                                   
+# Detailed Partition Information                                               
    
+Database               default                                     
+Table                  f                                           
+Partition Values       [B=SPARK, C=2018-11-17 13:33:33]                        
    
+Location [not included in comparison]/{warehouse_dir}/f/B=SPARK/C=2018-11-17 
13%3A33%3A33                          
+Partition Parameters   [numFiles=1, totalSize=486, transient_lastDdlTime=[not 
included in comparison]]                     

Review Comment:
   well, at least the masking logic is already implemented for AS JSON and we 
can save some changes from this PR :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to