beliefer commented on code in PR #50059:
URL: https://github.com/apache/spark/pull/50059#discussion_r1970897081
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1383,28 +1383,25 @@ class SparkConnectPlanner(
isStreaming = rel.getIsStreaming)
case proto.Read.ReadTypeCase.DATA_SOURCE if !rel.getIsStreaming =>
- val localMap =
CaseInsensitiveMap[String](rel.getDataSource.getOptionsMap.asScala.toMap)
val reader = session.read
- if (rel.getDataSource.hasFormat) {
- reader.format(rel.getDataSource.getFormat)
- }
- localMap.foreach { case (key, value) => reader.option(key, value) }
if (rel.getDataSource.getFormat == "jdbc" &&
rel.getDataSource.getPredicatesCount > 0) {
- if (!localMap.contains(JDBCOptions.JDBC_URL) ||
- !localMap.contains(JDBCOptions.JDBC_TABLE_NAME)) {
+ if
(!rel.getDataSource.getOptionsMap.containsKey(JDBCOptions.JDBC_URL) ||
+
!rel.getDataSource.getOptionsMap.containsKey(JDBCOptions.JDBC_TABLE_NAME)) {
throw InvalidPlanInput(s"Invalid jdbc params, please specify jdbc
url and table.")
}
val url = rel.getDataSource.getOptionsMap.get(JDBCOptions.JDBC_URL)
val table =
rel.getDataSource.getOptionsMap.get(JDBCOptions.JDBC_TABLE_NAME)
- val options = new JDBCOptions(url, table, localMap)
val predicates = rel.getDataSource.getPredicatesList.asScala.toArray
- val parts: Array[Partition] = predicates.zipWithIndex.map { case
(part, i) =>
- JDBCPartition(part, i): Partition
- }
- val relation = JDBCRelation(parts, options)(session)
- LogicalRelation(relation)
+ val properties = new Properties()
+ properties.putAll(rel.getDataSource.getOptionsMap)
+ reader.jdbc(url, table, predicates,
properties).queryExecution.analyzed
Review Comment:
Yes. `reader.load()` could support that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
