szehon-ho commented on code in PR #50031: URL: https://github.com/apache/spark/pull/50031#discussion_r1970429680
########## sql/api/src/test/scala/org/apache/spark/sql/StaticProcedureSuiteBase.scala: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +// scalastyle:off funsuite +import org.scalatest.funsuite.AnyFunSuite + +trait StaticProcedureSuiteBase extends AnyFunSuite { Review Comment: Yea I took a quick look when making this test run on both environments, it seems createProcedure (used in ProcedureSuite) is harder to do in the connect test environment as direct access to the catalog is currently not possible. We could maybe investigate it further in subsequent ticket? There's only one example that I know , that @cloud-fan pointed out in https://github.com/apache/spark/pull/50031#discussion_r1967751946 Other difficulties is , QueryTest.checkResult which is quite popular, is actually different classes in connect and sql test to avoid adding test dependencies in connect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
