vladimirg-db commented on code in PR #50069: URL: https://github.com/apache/spark/pull/50069#discussion_r1970308036
########## sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala: ########## @@ -2721,6 +2721,39 @@ class DataFrameSuite extends QueryTest parameters = Map("name" -> ".whatever") ) } + + test("Nested order by") { Review Comment: One more example that we should add: ``` val df1 = spark.sql("SELECT * FROM VALUES (4,5,6), (1,2,3)") val df2 = df1.select("col1").orderBy("col2") val df3 = df1.select("col1").orderBy(df1("col2")) // Cannot order by missing attribute under SubqueryAlias val df4 = df3.as("q1").orderBy("col3") val df5 = df3.as("q1").orderBy(df1("col3")) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org