hvanhovell commented on code in PR #50013:
URL: https://github.com/apache/spark/pull/50013#discussion_r1968734181
##########
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala:
##########
@@ -1248,6 +1263,11 @@ class LogisticRegressionModel private[spark] (
}
}
+ private[spark] override def estimatedSize: Long = {
+ SizeEstimator.estimate((this.params, this.uid,
Review Comment:
NIT: Can we just make the SizeEstimator take varargs instead of creating a
tuple here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
