viirya commented on code in PR #50044: URL: https://github.com/apache/spark/pull/50044#discussion_r1968152464
########## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala: ########## @@ -718,6 +724,11 @@ private class BufferedRowsReader( schema: StructType, row: InternalRow): Any = { val index = schema.fieldIndex(field.name) + + if (index >= row.numFields) { Review Comment: This is method `extractFieldValue`. Looks like it is only used by `get`. Why this is for adding columns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org