cloud-fan commented on code in PR #50026:
URL: https://github.com/apache/spark/pull/50026#discussion_r1967012051
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -206,6 +207,15 @@ class TriggerToExceptionHandlerMap(
def getNotFoundHandler: Option[ExceptionHandlerExec] = notFoundHandler
}
+object TriggerToExceptionHandlerMap {
+ def empty: TriggerToExceptionHandlerMap = new TriggerToExceptionHandlerMap(
Review Comment:
let's be very cautious about any global state. Can we write detailed comment
to explain how this global state is used and cleanup? Or try our best to not
use this global state.
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -206,6 +207,15 @@ class TriggerToExceptionHandlerMap(
def getNotFoundHandler: Option[ExceptionHandlerExec] = notFoundHandler
}
+object TriggerToExceptionHandlerMap {
+ def empty: TriggerToExceptionHandlerMap = new TriggerToExceptionHandlerMap(
Review Comment:
let's be very cautious about any global state. Can we write detailed comment
to explain how this global state is used and cleaned up? Or try our best to not
use this global state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
