LuciferYang commented on code in PR #50049:
URL: https://github.com/apache/spark/pull/50049#discussion_r1966678318
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/logical/DistinctKeyVisitorSuite.scala:
##########
@@ -47,9 +45,6 @@ class DistinctKeyVisitorSuite extends PlanTest {
assert(plan.analyze.distinctKeys === distinctKeys)
}
- implicit private def productEncoder[T <: Product : TypeTag]:
ExpressionEncoder[T] =
Review Comment:
I didn't find any evidence of it being used, and it was even deemed unused
in the initial pr.
However, since there are concerns, I have reverted the changes to it in the
latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
