beliefer commented on code in PR #48431: URL: https://github.com/apache/spark/pull/48431#discussion_r1966483977
########## common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala: ########## @@ -85,20 +85,20 @@ private[spark] object SparkThrowableHelper { toJsonString { generator => val g = generator.useDefaultPrettyPrinter() g.writeStartObject() - g.writeStringField("errorClass", "LEGACY") + g.writeStringField("condition", "LEGACY") Review Comment: How about `errorCondition`? The name `condition` makes confusion for developers who not read the document common/utils/src/main/resources/error/README.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org