viirya commented on code in PR #50037:
URL: https://github.com/apache/spark/pull/50037#discussion_r1964993314
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala:
##########
@@ -70,8 +70,9 @@ class IncrementalExecution(
val currentStateStoreCkptId:
MutableMap[Long, Array[Array[String]]] = MutableMap[Long,
Array[Array[String]]](),
val stateSchemaMetadatas: MutableMap[Long, StateSchemaBroadcast] =
- MutableMap[Long, StateSchemaBroadcast]())
- extends QueryExecution(sparkSession, logicalPlan) with Logging {
+ MutableMap[Long, StateSchemaBroadcast](),
+ mode: CommandExecutionMode.Value = CommandExecutionMode.ALL)
+ extends QueryExecution(sparkSession, logicalPlan, mode = mode) with Logging {
Review Comment:
> What happens? withCachedData is called infinitely (haven't followed about
why it made a loop) and ended up with StackOverflowError.
I don't trace it. So referring the question in that PR, why this mode causes
a loop which leads to StackOverflowError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
