cloud-fan commented on code in PR #50005:
URL: https://github.com/apache/spark/pull/50005#discussion_r1964832187
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala:
##########
@@ -30,9 +29,9 @@ import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Strategy
import org.apache.spark.sql.internal.SQLConf
class SparkPlanner(val session: SparkSession, val experimentalMethods:
ExperimentalMethods)
- extends SparkStrategies with SQLConfHelper {
+ extends SparkStrategies {
- override def conf: SQLConf = session.sessionState.conf
+ protected def conf: SQLConf = session.sessionState.conf
Review Comment:
Although `SparkPlanner` is a private API, it's meaningless to break the API
(`def conf` becomes protected instead of public) for no good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
