zhengruifeng commented on code in PR #50019:
URL: https://github.com/apache/spark/pull/50019#discussion_r1964664635
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -67,15 +67,16 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
def outputOrdering: Seq[SortOrder] = Nil
// Override `treePatternBits` to propagate bits for its expressions.
- override lazy val treePatternBits: BitSet = {
+ private val _treePatternBits = new BestEffortLazyVal[BitSet](() => {
Review Comment:
`treePatternBits` was kept `lazy val` in [previous
PR](https://github.com/apache/spark/pull/49212), do you @cloud-fan remember it
was intended or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
