Kimahriman commented on code in PR #50006:
URL: https://github.com/apache/spark/pull/50006#discussion_r1963507017
##########
python/pyspark/sql/connect/session.py:
##########
@@ -1041,11 +1045,17 @@ def _start_connect_server(master: str, opts: Dict[str,
Any]) -> None:
init_opts.update(opts)
opts = init_opts
+ token = str(uuid.uuid4())
+
# Configurations to be overwritten
overwrite_conf = opts
overwrite_conf["spark.master"] = master
overwrite_conf["spark.local.connect"] = "1"
+ # When running a local server, always use an ephemeral port
+ overwrite_conf["spark.connect.grpc.binding.port"] = "0"
+ overwrite_conf["spark.connect.authenticate.token"] = token
os.environ["SPARK_LOCAL_CONNECT"] = "1"
+ os.environ["SPARK_CONNECT_AUTHENTICATE_TOKEN"] = token
Review Comment:
Okay I changed things around a little bit:
- The unit tests set a static token value via the config
- When starting the local session, we check if the env var is already set
and use that if it is, otherwise if the config is set we set the env var to
that, otherwise generate a new token and set the env var
- Don't set the config for the auto started server, just let the env var set
the token on the server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
