cloud-fan commented on code in PR #49955: URL: https://github.com/apache/spark/pull/49955#discussion_r1959744172
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ########## @@ -1031,6 +1040,9 @@ object ColumnPruning extends Rule[LogicalPlan] { } else { p } + // TODO: Pruning `UnionLoop`s needs to take into account both the outer `Project` and the inner + // `UnionLoopRef` nodes. Review Comment: This might hurt performance a lot. Let's figure it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org