HeartSaVioR commented on code in PR #49304:
URL: https://github.com/apache/spark/pull/49304#discussion_r1957584484
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateEncoder.scala:
##########
@@ -1814,18 +1663,17 @@ class NoPrefixKeyStateEncoder(
rowBytes.length
)
- encodeStateRowWithPrefix(dataWithVersion)
+ dataWithVersion
}
}
override def decodeKey(keyBytes: Array[Byte]): UnsafeRow = {
if (!useColumnFamilies) {
- dataEncoder.decodeKey(decodeStateRowData(keyBytes))
+ dataEncoder.decodeKey(keyBytes)
Review Comment:
ditto if the above is turned out to be a bug.
If the above is a bug, this cannot read from existing checkpoint from prior
Spark versions. (Though probably we didn't make release of multiple column
family?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
