szehon-ho commented on code in PR #49963:
URL: https://github.com/apache/spark/pull/49963#discussion_r1957065310
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -148,9 +148,9 @@ object ComputeCurrentTime extends Rule[LogicalPlan] {
case class ReplaceCurrentLike(catalogManager: CatalogManager) extends
Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
- val currentNamespace = catalogManager.currentNamespace.quoted
- val currentCatalog = catalogManager.currentCatalog.name()
- val currentUser = CurrentUserContext.getCurrentUser
+ lazy val currentNamespace = catalogManager.currentNamespace.quoted
+ lazy val currentCatalog = catalogManager.currentCatalog.name()
+ lazy val currentUser = CurrentUserContext.getCurrentUser
Review Comment:
OK , i thought one line is a bit harder to read. I moved the val to be in
the cases, is it better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
