ueshin commented on code in PR #49946:
URL: https://github.com/apache/spark/pull/49946#discussion_r1956676096
##########
bin/pyspark:
##########
@@ -83,6 +83,8 @@ export
PYTHONPATH="${SPARK_HOME}/python/lib/py4j-0.10.9.9-src.zip:$PYTHONPATH"
export OLD_PYTHONSTARTUP="$PYTHONSTARTUP"
export PYTHONSTARTUP="${SPARK_HOME}/python/pyspark/shell.py"
+export PYSPARK_DEFAULT_API_MODE=$($PYSPARK_DRIVER_PYTHON -c "from pyspark.util
import default_api_mode; print(default_api_mode())")
Review Comment:
> if the module does not exist, this export will ignore the error and leave
the variable unset?
If the module does not exist, it will contain an error message from the
Python command.
I'll add error check for the value, and show an error message and unset
`SPARK_CONNECT_MODE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
