cloud-fan commented on code in PR #49930:
URL: https://github.com/apache/spark/pull/49930#discussion_r1956401549
##########
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java:
##########
@@ -151,6 +151,11 @@ class SparkSubmitCommandBuilder extends
AbstractCommandBuilder {
OptionParser parser = new OptionParser(true);
parser.parse(submitArgs);
this.isSpecialCommand = parser.isSpecialCommand;
+ String defaultApiMode = "1".equals(System.getenv("SPARK_CONNECT_MODE"))
? "connect" : "classic";
Review Comment:
```suggestion
boolean connectByDefault =
"1".equals(System.getenv("SPARK_CONNECT_MODE"))
String defaultApiMode = connectByDefault ? "connect" : "classic";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
