grundprinzip commented on code in PR #49948:
URL: https://github.com/apache/spark/pull/49948#discussion_r1955811893
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLCache.scala:
##########
@@ -76,3 +83,11 @@ private[connect] class MLCache extends Logging {
cachedModel.clear()
}
}
+
+private[connect] object MLCache {
+ // The maximum number of distinct items in the cache.
+ private val MAX_CACHED_ITEMS = 100
Review Comment:
What happens if we can't find an item in the cache, do we throw a proper
exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
