LuciferYang commented on code in PR #47084:
URL: https://github.com/apache/spark/pull/47084#discussion_r1954366720
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -306,11 +296,9 @@ class SimpleFunctionRegistry
extends SimpleFunctionRegistryBase[Expression]
with FunctionRegistry {
- override def clone(): SimpleFunctionRegistry = synchronized {
+ override def clone(): SimpleFunctionRegistry = {
Review Comment:
Originally, this entire function was atomic. If there are additions or
deletions to functionBuilders during the cloning process, it would deviate from
the previous behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
