dongjoon-hyun commented on code in PR #49813:
URL: https://github.com/apache/spark/pull/49813#discussion_r1953096507
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/ClientE2ETestSuite.scala:
##########
@@ -228,11 +228,12 @@ class ClientE2ETestSuite
}
test("spark deep recursion") {
+ var recursionDepth = if (System.getProperty("os.arch") == "s390x") 400
else 500
Review Comment:
Yes, please test it without Java 21 too.
For the other stuff, you can revise the PR description by narrowing down the
scope. Currently, for me, it claims too much. The code itself looks reasonable
to me. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
