cnauroth commented on code in PR #49878:
URL: https://github.com/apache/spark/pull/49878#discussion_r1950268117
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2405,7 +2405,8 @@ class SparkContext(config: SparkConf) extends Logging {
ResourceProfile.clearDefaultProfile()
// Unset YARN mode system env variable, to allow switching between cluster
types.
SparkContext.clearActiveContext()
- logInfo("Successfully stopped SparkContext")
+ logInfo(log"Successfully stopped SparkContext (Uptime: " +
Review Comment:
A minor objection here that `startTime` and this calculation are derived
from `System.currentTimeMllis()`, which is subject to clock skew and system
time resets. However, I haven't investigated what it would take to migrate this
code path to the more reliable `System#nanoTime()`.
Regardless, a nice improvement, and +1 (non-binding)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
