yaooqinn commented on code in PR #48748:
URL: https://github.com/apache/spark/pull/48748#discussion_r1950205886
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -1147,6 +1147,77 @@ object functions {
*/
def sum_distinct(e: Column): Column = Column.fn("sum", isDistinct = true, e)
+ /**
+ * Aggregate function: returns the concatenation of non-null input values.
+ *
+ * @group agg_funcs
+ * @since 4.0.0
+ */
+ def listagg(e: Column): Column = Column.fn("listagg", e)
+
+ /**
+ * Aggregate function: returns the concatenation of non-null input values,
separated by the
+ * delimiter.
+ *
+ * @group agg_funcs
+ * @since 4.0.0
+ */
+ def listagg(e: Column, delimiter: Column): Column = Column.fn("listagg", e,
delimiter)
Review Comment:
Declaring the delimiter as String here can improve UX a bit. Since it only
allows foldable string literals, we can rely on the compiler errors instead of
runtime ones, WDYT @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
