zhengruifeng commented on code in PR #49862:
URL: https://github.com/apache/spark/pull/49862#discussion_r1948375370
##########
sql/connect/common/src/main/protobuf/spark/connect/ml_common.proto:
##########
@@ -33,24 +33,32 @@ message MlParams {
// MLOperator represents the ML operators like (Estimator, Transformer or
Evaluator)
message MlOperator {
- // The qualified name of the ML operator.
+ // (Required) The qualified name of the ML operator.
string name = 1;
- // Unique id of the ML operator
+
+ // (Required) Unique id of the ML operator
string uid = 2;
- // Represents what the ML operator is
+
+ // (Required) Represents what the ML operator is
OperatorType type = 3;
+
enum OperatorType {
- UNSPECIFIED = 0;
- ESTIMATOR = 1;
- TRANSFORMER = 2;
- EVALUATOR = 3;
- MODEL = 4;
+ OPERATOR_TYPE_UNSPECIFIED = 0;
Review Comment:
rename to follow the protobuf style guide
https://protobuf.dev/programming-guides/style/#enums
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
