cloud-fan commented on code in PR #32987:
URL: https://github.com/apache/spark/pull/32987#discussion_r1948344607
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala:
##########
@@ -99,34 +111,37 @@ class EquivalentExpressions(
* only the common nodes.
* Those common nodes are then removed from the local map and added to the
final map of
* expressions.
+ *
+ * Conditional expressions are not considered because we are simply looking
for expressions
+ * evaluated once in each parent expression.
*/
- private def updateCommonExprs(
- exprs: Seq[Expression],
- map: mutable.HashMap[ExpressionEquals, ExpressionStats],
Review Comment:
shall we update the doc of this method? no equivalenceMap in this method now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
