vruusmann commented on PR #49854: URL: https://github.com/apache/spark/pull/49854#issuecomment-2646143491
A quick memory dump on JPMML-Model evolution: - `1.5.X`. Migrating from PMML schema 4.3 to 4.4. JDK 8 compatible. - `1.6.X`. API upgrades. Specifically, replacing `org.dmg.pmml.FieldName` (pseudo-enum for representing field names) with plain `java.lang.String`. Also, migrating from `javax.xml.bind.*` API to `jakarta.xml.bind.*` API. JDK 8 compatible. - `1.7.X`. Upgrading from JDK 8 to JDK 11. The codebase is effectively unchanged. Just picking up up-to-date dependencies. The `org.glassfish.jaxb:jaxb-*` dependencies are chosen based on their JDK compaibility. For example, `org.glassfish.jaxb:jaxb-runtime:3.X` versions are targeting JDK 8, whereas `org.glassfish.jaxb:jaxb-runtime:4.X` are targeting JDK 11. Apache Spark 4.X is targeting JDK 17, no? As for encoding PMML schema versions and XML namespaces, then there's a `org.dmg.pmml.Version` enum class for this purpose. You could define a class constant `SPARK_PMML_VERSION` somewhere, and then access its `#version` and `#namespaceURI` string attributes: ```java org.dmg.pmml.Version SPARK_PMML_VERSION = org.dmg.pmml.Version.PMML_4_4; System.out.println(SPARK_PMML_VERSION .getVersion()); // Prints "4.4" System.out.println(SPARK_PMML_VERSION.getNamespaceURI()); // Prints "http://www.dmg.org/PMML-4_4"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
