davidm-db commented on code in PR #49726: URL: https://github.com/apache/spark/pull/49726#discussion_r1946412244
########## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala: ########## @@ -1020,3 +1023,105 @@ class ExceptionHandlerExec( override def reset(): Unit = body.reset() } + +/** + * Executable node for Signal Statement. + * @param errorCondition Name of the error condition/SQL State for error that will be thrown. + * @param sqlState SQL State of the error that will be thrown. + * @param message Error message (either string or variable name). + * @param msgArguments Error message parameters for builtin conditions. + * @param session Spark session that SQL script is executed within. + */ +class SignalStatementExec( + val errorCondition: Option[String] = None, + val sqlState: Option[String] = None, Review Comment: as mentioned in one of the previous comments, let's make these mandatory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
