cloud-fan commented on code in PR #49445:
URL: https://github.com/apache/spark/pull/49445#discussion_r1946116964


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -269,6 +269,94 @@ class SqlScriptingParserSuite extends SparkFunSuite with 
SQLHelper {
     assert(exception.origin.line.contains(3))
   }
 
+  test("compound: forbidden label - system") {

Review Comment:
   another choose is we let it go and define that local variable has higher 
priority than session variable. cc @srielau 



##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -269,6 +269,94 @@ class SqlScriptingParserSuite extends SparkFunSuite with 
SQLHelper {
     assert(exception.origin.line.contains(3))
   }
 
+  test("compound: forbidden label - system") {

Review Comment:
   another choice is we let it go and define that local variable has higher 
priority than session variable. cc @srielau 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to