miland-db commented on code in PR #49726:
URL: https://github.com/apache/spark/pull/49726#discussion_r1944478910
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SqlScriptingLogicalPlans.scala:
##########
@@ -405,3 +406,25 @@ case class ExceptionHandler(
handlerType)
}
}
+
+/**
+ * Logical operator for Signal Statement.
+ * @param isBuiltinError Flag indicating if the error is a builtin error.
+ * @param errorCondition Name of the error condition/SQL State for error that
will be thrown.
+ * @param sqlState SQL State for error that will be thrown.
+ * @param message Error message (either string or variable name).
+ * @param messageArguments Arguments to fill builtin error message
placeholders.
+ */
+case class SignalStatement(
+ var isBuiltinError: Boolean = false,
+ errorCondition: Option[String] = None,
+ var sqlState: Option[String] = None,
Review Comment:
`sqlState` is resolved later for some kind of `SIGNAL` statements and not
during parsing. I need a way to set it when I resolve it. One way is to create
a new instance where we copy everything from the existing instance and provide
new resolved `sqlState`, or to use `var`. Any thoughts @cloud-fan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
