LuciferYang commented on code in PR #49825:
URL: https://github.com/apache/spark/pull/49825#discussion_r1944189956
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ShuffleTransportContextSuite.java:
##########
@@ -114,16 +115,17 @@ public void testDecodeOfFinalizeShuffleMessage() throws
Exception {
FinalizeShuffleMerge finalizeRequest = new FinalizeShuffleMerge("app0", 1,
2, 3);
RpcRequest rpcRequest = new RpcRequest(1, new
NioManagedBuffer(finalizeRequest.toByteBuffer()));
ByteBuf messageBuf = getDecodableMessageBuf(rpcRequest);
- ShuffleTransportContext shuffleTransportContext =
createShuffleTransportContext(true);
- ShuffleTransportContext.ShuffleMessageDecoder decoder =
+ try (ShuffleTransportContext shuffleTransportContext =
createShuffleTransportContext(true)) {
+ ShuffleTransportContext.ShuffleMessageDecoder decoder =
(ShuffleTransportContext.ShuffleMessageDecoder)
shuffleTransportContext.getDecoder();
- List<Object> out = Lists.newArrayList();
- decoder.decode(mock(ChannelHandlerContext.class), messageBuf, out);
+ List<Object> out = Lists.newArrayList();
+ decoder.decode(mock(ChannelHandlerContext.class), messageBuf, out);
- Assertions.assertEquals(1, out.size());
- Assertions.assertTrue(out.get(0) instanceof
ShuffleTransportContext.RpcRequestInternal);
- Assertions.assertEquals(BlockTransferMessage.Type.FINALIZE_SHUFFLE_MERGE,
+ Assertions.assertEquals(1, out.size());
+
Assertions.assertInstanceOf(ShuffleTransportContext.RpcRequestInternal.class,
out.get(0));
Review Comment:
can use `assertInstanceOf` in JUnit 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
