wayneguow commented on PR #48611: URL: https://github.com/apache/spark/pull/48611#issuecomment-2638825365
> @LuciferYang and @wayneguow > > It seems we need to change the code for `pmml-model` 1.4.8 -> 1.7.1 upgrade, so I am a bit worry about the compatibility, I suggest: 1, splitting this PR, can we make a separate PR for `pmml-model` upgrade first? 2, adding additional tests to make sure `pmml-model 1.7.1` can successfully load previous models. We can save 1~2 pmml models into `mllib/src/test/resources/ml-models` with Spark 3.5, and then load them in the tests. you can refer to [6b7527e](https://github.com/apache/spark/commit/6b7527e381591bcd51be205853aea3e349893139) > > also cc @WeichenXu123 Okay, I agree with your suggestion, let me first ensure that `pmml-model` can be upgraded without loss of compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
