anishshri-db commented on code in PR #49560:
URL: https://github.com/apache/spark/pull/49560#discussion_r1943587513


##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -317,21 +313,16 @@ def check_results(batch_df, batch_id):
                     Row(id="0", countAsString="2"),
                     Row(id="1", countAsString="2"),
                 }
-            elif batch_id == 1:
+            else:
                 assert set(batch_df.sort("id").collect()) == {
                     Row(id="0", countAsString="3"),
                     Row(id="1", countAsString="2"),
                 }
-            else:
-                for q in self.spark.streams.active:
-                    q.stop()
 
         self._test_transform_with_state_in_pandas_basic(
             SimpleTTLStatefulProcessor(), check_results, False, 
"processingTime"
         )
 
-    # TODO SPARK-50908 holistic fix for TTL suite
-    @unittest.skip("test is flaky and it is only a timing issue, skipping 
until we can resolve")

Review Comment:
   Yea if its not related to the connect change - lets file a separate PR for 
this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to