cloud-fan commented on code in PR #49107:
URL: https://github.com/apache/spark/pull/49107#discussion_r1942364924
##########
core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala:
##########
@@ -52,9 +53,12 @@ object PythonRunner {
// Format python file paths before adding them to the PYTHONPATH
val formattedPythonFile = formatPath(pythonFile)
val formattedPyFiles = resolvePyFiles(formatPaths(pyFiles))
+ lazy val apiMode = sparkConf.get(SPARK_API_MODE).toLowerCase(Locale.ROOT)
+ lazy val isAPIModeClassic = apiMode == "classic"
+ lazy val isAPIModeConnect = apiMode == "connect"
Review Comment:
nit: simple computation doesn't warrant a lazy val, we can just use `def`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
